Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten permissions of ROBOCORP_HOME base (Windows only) #647

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Tighten permissions of ROBOCORP_HOME base (Windows only) #647

merged 2 commits into from
Nov 26, 2024

Conversation

jherbel
Copy link
Contributor

@jherbel jherbel commented Nov 21, 2024

No description provided.

@jherbel jherbel force-pushed the dev/joerg/CMK-20325_tighten_permissions_robocorp_home branch 2 times, most recently from 2916672 to 5780aa4 Compare November 21, 2024 10:10
@jherbel jherbel requested a review from SoloJacobs November 21, 2024 10:14
SoloJacobs
SoloJacobs previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@SoloJacobs SoloJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with nit

tests/test_scheduler.rs Show resolved Hide resolved
@jherbel jherbel force-pushed the dev/joerg/CMK-20325_tighten_permissions_robocorp_home branch from 5780aa4 to 5204f72 Compare November 21, 2024 15:06
@jherbel jherbel requested a review from SoloJacobs November 21, 2024 15:06
@jherbel jherbel force-pushed the dev/joerg/CMK-20325_tighten_permissions_robocorp_home branch 4 times, most recently from 850bfc4 to c11049c Compare November 26, 2024 11:58
@jherbel
Tighten permissions of ROBOCORP_HOME base (Windows only)
003333e 
* Remove inherited permissions
* Grant Administrators group full access

CMK-20325
@jherbel jherbel marked this pull request as draft November 26, 2024 12:24
@jherbel jherbel force-pushed the dev/joerg/CMK-20325_tighten_permissions_robocorp_home branch 2 times, most recently from 3b88b34 to 0a15a39 Compare November 26, 2024 12:47
@jherbel jherbel marked this pull request as ready for review November 26, 2024 13:00
@jherbel jherbel merged commit 4357dbf into main Nov 26, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@jherbel jherbel deleted the dev/joerg/CMK-20325_tighten_permissions_robocorp_home branch November 26, 2024 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SoloJacobs SoloJacobs SoloJacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jherbel @SoloJacobs